Skip to content

Include QString #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

Include QString #1298

merged 1 commit into from
Nov 13, 2024

Conversation

mjforan
Copy link
Contributor

@mjforan mjforan commented Nov 12, 2024 •
edited
Loading

Adds #include <QString> to all files which use QString.

Addresses @clalancette's comment here. The linter's "include what you use" rule does not work on this header. Probably other QT headers as well, but this is the most common.

@mjforan mjforan requested a review from ahcorde as a code owner November 12, 2024 20:11
@ahcorde
Copy link
Contributor

ahcorde commented Nov 12, 2024

Pulls: #1298
Gist: https://gist.githubusercontent.com/ahcorde/1453a997533c1caec0186b8c578031a6/raw/88b5b66f9df531bcbe781bc48d285e773327c393/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_common rviz_default_plugins rviz_visual_testing_framework rviz_rendering --packages-above-and-dependencies rviz_common rviz_default_plugins rviz_visual_testing_framework rviz_rendering
TEST args: --packages-above rviz_common rviz_default_plugins rviz_visual_testing_framework rviz_rendering --packages-above rviz_common rviz_default_plugins rviz_visual_testing_framework rviz_rendering
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14812

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 9a94bdf into ros2:rolling Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjforan @ahcorde